Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation requires changes in code (start_server.sh) #23

Closed
netsensei opened this issue Aug 6, 2015 · 0 comments
Closed

Installation requires changes in code (start_server.sh) #23

netsensei opened this issue Aug 6, 2015 · 0 comments
Assignees

Comments

@netsensei
Copy link
Contributor

Per the installation instructions:

Edit the start_server.sh script in the supervisor-directory and update the following configuration settings:

This means you have to alter the code of the application in order to configure it for your environment.

Such a setup is pretty much unmaintainable for application managers. More so if they are using automated tools to roll out updates or changes to the code. Chances are that this file will be overwritten on future updates.

Conceivable, a maintainer could exclude this file from receiving (automated) updates. But a future update contains a code change / bugfix in this file, the maintainer is required to manually edit / integrate that change.

Suggestion: Since it's a bash script: use environment variables instead and use add a ~/.resolver/config file of sorts. It's up to the application manager to include the configuration in their dot files so the run_server.sh script picks it up automatically.

@pieterdp pieterdp self-assigned this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants