-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIDAS bug fixes for assembling Muddle #826
Comments
I think the next version of MIDAS should be 459 rather than incremented for every bugfix or git commit. |
Also add the INFO; MIDAS ARCHIV file. |
MIDAS 323 can multiply a global symbol with a constant. See e.g. MUDSYS; SAVE 176, MIDAS 458 won't do that. It'll complain saying "Externals multiplied". Checking the diff, it seems the logic at label MULTP1 has been arranged somewhat. The 323 version seems to work, but supposedly the change was made for a reason. Some testcases and careful single-stepping should reveal the intent. |
To summarise the changes we made to MIDAS 323 when we were using it for building Muddle:
We're now using MIDAS 73 for Muddle, so none of these are strictly necessary, although it would be nice to include the last two in 459 for posterity. It may well be that the other older code we're building with 323 would actually build with 73/77, so 323 itself might not be necessary. |
Unless 323 is necessary to build 77?
|
At present we build 73 using a binary of 77 - neither 73 nor 77 will build with 323. |
@atsampson has found a number of problems in MIDAS when using it to assemble Muddle.
Check #665 for gory details.
Also, he's been using MIDAS 323 because 328 and later doesn't work. So see what the difference is and fix it. (73, 289, and 308 also work.)
The text was updated successfully, but these errors were encountered: