Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report backend improvements #134

Closed
1 task done
nebfield opened this issue Jul 31, 2023 · 2 comments · Fixed by #244
Closed
1 task done

Report backend improvements #134

nebfield opened this issue Jul 31, 2023 · 2 comments · Fixed by #244
Labels
enhancement New feature or request

Comments

@nebfield
Copy link
Member

nebfield commented Jul 31, 2023

Description of feature

Some things to improve building and updating the output report:

  • Use renv to capture dependencies in a lock file to improve stability / reproducibility (I'm manually building container images currently)

These won't affect the content of the report but instead change how the report is built

@nebfield nebfield added the enhancement New feature or request label Jul 31, 2023
@nebfield nebfield added this to the v2.1.0 milestone Jul 31, 2023
@smlmbrt
Copy link
Member

smlmbrt commented Aug 4, 2023

I'd prefer to not make a package - I like that it's easy to see and edit the report in this repository

@smlmbrt
Copy link
Member

smlmbrt commented Aug 11, 2023

Also we need to version the report environment, using dev causes problems for new runs of the pipeline:

withLabel: report {
ext.conda = "$projectDir/environments/report/environment.yml"
ext.singularity = 'oras://dockerhub.ebi.ac.uk/gdp-public/pgsc_calc/singularity/report'
ext.singularity_version = ':dev'
ext.docker = 'dockerhub.ebi.ac.uk/gdp-public/pgsc_calc/report'
ext.docker_version = ':dev'
}

@nebfield nebfield mentioned this issue Mar 19, 2024
7 tasks
@nebfield nebfield linked a pull request Mar 19, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants