Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get methods of pyphare.Run should not specify the file where py_attrs are retrieved from #814

Open
rochSmets opened this issue Mar 6, 2024 · 1 comment
Assignees
Milestone

Comments

@rochSmets
Copy link
Contributor

In the methods GetDomainSize and GetDl of pyphare/run.py, the file where the attributes are is specified. Hence, These methods won't work if the file does not exist. A better strategy should be to list all the h5 files of the run, and get one (whatever, they all contain the same attrs) to deserialize the needed quantity (that is cell_width and domain_box)

@rochSmets rochSmets changed the title Get methods of pyphar.eRun should not specify the file where py_attrs are retrieved from Get methods of pyphare.Run should not specify the file where py_attrs are retrieved from Mar 6, 2024
@PhilipDeegan
Copy link
Member

there will be a mechanism to get all available data from h5 files: see https://github.com/PhilipDeegan/PHARE/blob/refac_hierarchies/pyphare/pyphare/pharesee/hierarchy/fromh5.py#L27

for global simulation information (like GetDomainSize) this should be adequate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Fix me 🔥
Development

No branches or pull requests

3 participants