We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently in both solver_ppc and Ion_Updater::updateAndDepositDomain_ we copy the patch ghosts per patch during advance.
solver_ppc
Ion_Updater::updateAndDepositDomain_
It's possible that one of these might be redudant.
Having tried removing the copy from solver_ppc, we see test failures in test_advance::_test_L0_particle_number_conservation
test_advance::_test_L0_particle_number_conservation
with particle count mismatch,
however if we remove the copy in updater, we only see test failures in test_updater.cpp @
TYPED_TEST(IonUpdaterTest, particlesUntouchedInMomentOnlyMode)
which might just not make sense anymore
the above can be seen on my fork @ PhilipDeegan#91
The text was updated successfully, but these errors were encountered:
nicolasaunai
No branches or pull requests
Currently in both
solver_ppc
andIon_Updater::updateAndDepositDomain_
we copy the patch ghosts per patch during advance.It's possible that one of these might be redudant.
Having tried removing the copy from solver_ppc, we see test failures in
test_advance::_test_L0_particle_number_conservation
with particle count mismatch,
however if we remove the copy in updater, we only see test failures in test_updater.cpp @
TYPED_TEST(IonUpdaterTest, particlesUntouchedInMomentOnlyMode)
which might just not make sense anymore
the above can be seen on my fork @ PhilipDeegan#91
The text was updated successfully, but these errors were encountered: