-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Bulk Action on Connection and Engine #24
Comments
I was just playing with loupe adapter and without batch support I was indexing ~5k recors about 35minutes, so I've implemented own reindexing and with 100 batch it did take around 30s. I guess performance will suffer on every adapter when importing more documents, so batch API is must. |
@zajca thx for giving SEAL a try and give feedback here. For the adapters not supporting batch or have seperate APIs for update/create and batch I'm planning to fallback to the normal APIs. So they may not have performance improvement but the API from outside for all adapters will be the same and so people using SEAL don't need create different code depending on the Adapters. |
this is in progress: #430 |
It should be possible to provide Bulk Action on Connection and Engine.
Engine not supporting bulk action can fallback to basic save and delete methods.
The
documents
should be able to be aryor \Generator for performance.A
BulkableIndexerInterface
should be added so the fallback to the save/delete can be part of the Engine and not every adapter itself need to implement it.Bulk Action make maybe sense in case of:
Implementing of Reindex Providers #16
The text was updated successfully, but these errors were encountered: