From eb5932a20bd3526aa0373d640cda475c82e8c706 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 11 Dec 2022 08:03:30 +0100 Subject: [PATCH] GH Actions: selectively use `fail-fast` with setup-php I've seen some recent build failures due to the `setup-php` action running into a rate limit and not downloading the required version of Composer. In the case of this package, that would make the test runs worthless. The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run. So, specifically for those jobs where the Composer version is important, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors. Ref: https://github.com/shivammathur/setup-php#fail-fast-optional --- .github/workflows/integrationtest.yml | 1 + .github/workflows/quicktest.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/integrationtest.yml b/.github/workflows/integrationtest.yml index 20b0ff88..436d81f0 100644 --- a/.github/workflows/integrationtest.yml +++ b/.github/workflows/integrationtest.yml @@ -122,6 +122,7 @@ jobs: ini-values: zend.assertions=1, error_reporting=-1, display_errors=On tools: "composer:${{ matrix.composer }}" coverage: none + fail-fast: true - name: "Conditionally disable tls (Composer 1.x/Windows/PHP 5.4)" if: ${{ matrix.os == 'windows-latest' && matrix.composer == 'v1' && matrix.php == '5.4' }} diff --git a/.github/workflows/quicktest.yml b/.github/workflows/quicktest.yml index 24205abd..3d13a74a 100644 --- a/.github/workflows/quicktest.yml +++ b/.github/workflows/quicktest.yml @@ -49,6 +49,7 @@ jobs: ini-values: zend.assertions=1, error_reporting=-1, display_errors=On tools: "composer:${{ matrix.composer }}" coverage: none + fail-fast: true - name: "Conditionally disable tls (Composer 1.x/Windows/PHP 5.4)" if: ${{ matrix.os == 'windows-latest' && matrix.composer == 'v1' && matrix.php == '5.4' }}