Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Add locateName() and getFromName() to PHPExcel_Shared_ZipArchive, Modify... #247

Closed
wants to merge 4 commits into from

Conversation

adamriyadi
Copy link

  • Add locateName() and getFromName() to PHPExcel_Shared_ZipArchive.
  • Modify PHPExcel_Reader_Excel2007 to use zipClass from PHPExcel_Settings::getZipClass()

…ify PHPExcel_Reader_Excel2007 to use zipClass from PHPExcel_Settings::getZipClass()
@adamriyadi adamriyadi closed this Sep 21, 2013
@adamriyadi adamriyadi reopened this Sep 21, 2013
MarkBaker pushed a commit that referenced this pull request Nov 17, 2013
MarkBaker pushed a commit that referenced this pull request Nov 17, 2013
…2007 to use zipClass from PHPExcel_Settings::getZipClass()

This allows the use of PCLZip when reading for people that don't have access to ZipArchive
@MarkBaker
Copy link
Member

Thanks for the PR... the only thing I've modified is to suppress the check for the $zipClass, because the ZipArchive class won't necessarily have been autoloaded prior to the first instantiation, so will throw an exception at that point. I'll take a look at how I can modify that check

@MarkBaker MarkBaker closed this Nov 17, 2013
@Progi1984 Progi1984 added this to the 1.8.0 milestone Aug 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants