This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Disabled libxml external entity loading by default. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to allow loading external entity references in XML, call PHPExcel_Settings::setLibXmlLoaderOptions(0).
maartenba
added a commit
that referenced
this pull request
Feb 21, 2014
Disabled libxml external entity loading by default.
|
Thanks for this Maarten, I've been kinda busy of late |
|
No worries. Can you prepare a release with this one in somewhere in the next days/weeks? |
|
I'm hoping I'll get the 1.8.0 release done before the end of this month, so it'll be included in that |
|
Already ahead on the Simple XML load rather than XML Reader: I've added it into the getLibXmlLoaderOptions() method so it's called every time.... perhaps not the cleanest way of doing it, but it does make it easier as we transition from SimpleXML to XMLReader |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to allow loading external entity references in XML, call PHPExcel_Settings::setLibXmlLoaderOptions(0).