Nested lists only works with invalid HTML

[rkorebrits]

This is a bug report

Expected Behavior

In HTML when nesting lists, the nested <ul> needs to be inside, at the end of the parent <li> node.

Current Behavior

E.g. Sample 26 uses invalid HTML to build HTML for the list.

The error message that I receive:

Type: BadMethodCallException
Message: Cannot add ListItemRun in ListItemRun.
Filename: /www/_ditto/ditto/vendor/phpoffice/phpword/src/PhpWord/Element/AbstractContainer.php
Line Number: 230

How to Reproduce

<?php
    public function runTest(){
        $phpWord = new \PhpOffice\PhpWord\PhpWord();
        $section = $phpWord->addSection();
        $html = '<h1>Adding element via HTML</h1>';

        // WRONG - but works
        $html .= '<ul><li>Item 1</li><li>Item 2</li><ul><li>Item 2.1</li><li>Item 2.1</li></ul></ul>';
        // RIGHT - But throws an error
        $html .= '<ul><li>Item 1</li><li>Item 2<ul><li>Item 2.1</li><li>Item 2.1</li></ul></li></ul>';

        \PhpOffice\PhpWord\Shared\Html::addHtml($section, $html, false, false);

        $objWriter = \PhpOffice\PhpWord\IOFactory::createWriter(
            $phpWord, 'Word2007'
        );

        $file_path_docx = 'test_bullets.docx';
        $objWriter->save($file_path_docx);
    }

To solve this for now, I've added a regex to extract the HTML to make it work:

    // First replace new lines by spaces
    $html = str_replace(["\r\n", "\n", "\r"], '', $html);
    // Extract UL from LI an place after
    $html = preg_replace('/(<li.*?>.*?)(<ul>.*?<\/ul>)\s?(<\/li>)/i', '$1$3$2', $html);

Not sure if it's the best regex, but for our solution it works.

Context

• PHP version: 7.1
• PHPWord version: latest dev

[troosan]

@rkorebrits I think this is a duplicate of #1265, it was fixed in #1273. It was merged here
Are you sure you are using the dev-develop branch?

[rkorebrits]

EDIT - Looks like composer wasn't updated properly
p.s. this doesn't resolve my other issue with <li> spacing

Apologies for duplicates!

Composer.json: "phpoffice/phpword": "dev-develop"

richard@ubuntu:/var/www/ditto$ composer update phpoffice/phpword
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Generating autoload files

composer.json inside package:

"extra": {
    "branch-alias": {
        "dev-master": "0.15-dev"
    }
}

Am I missing something?

[vladimirvalakh]

Some issue.
I'm using develop branch.

$section = $phpWord->addSection([
'marginLeft' => 600,
'marginRight' => 600,
'marginTop' => 600,
'marginBottom' => 600
]);

$html="<div><p>fdf</p><ul><li>123</li></ul></div>";

$section->addListItem(
    \PhpOffice\PhpWord\Shared\Html::addHtml($section, insertHtmlToList($html), false, false), 1, null);

have error:
PHP Fatal error: Uncaught BadMethodCallException: Cannot add ListItemRun in TextRun