Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dompdf version bump to include 3.0 when? #2621

Closed
2 tasks
jurchiks opened this issue Jun 10, 2024 · 1 comment · Fixed by #2666
Closed
2 tasks

dompdf version bump to include 3.0 when? #2621

jurchiks opened this issue Jun 10, 2024 · 1 comment · Fixed by #2666
Milestone

Comments

@jurchiks
Copy link

Describe the problem

Currently PHPWord only supports dompdf/dompdf ^2.0, but recently dompdf released v3: https://github.com/dompdf/dompdf/releases/tag/v3.0.0

Judging from the changelog and diff (dompdf/dompdf@v2.0.8...master), there don't seem to be any BC breaks, certainly no API breaks, aside from very few type additions to method signatures, which shouldn't break anything.

This would indicate that bumping the version requirement to dompdf/dompdf ^2.0 || ^3.0 shouldn't cause any problems.

Currently I cannot update my own dompdf version because it conflicts with the phpword requirement, which is, understandably, a pain in the ass.

Describe the expected behavior

Dompdf ^3.0 is supported.

Priority

  • I want to crowdfund the feature (with @algora-io) and fund a community developer.
  • I want to pay the feature and fund a maintainer for that. (Contact @Progi1984)
@Progi1984 Progi1984 added this to the 2.0.0 milestone Aug 10, 2024
@Progi1984 Progi1984 modified the milestones: 1.3.0, 1.3.1 Aug 31, 2024
@Progi1984 Progi1984 linked a pull request Sep 2, 2024 that will close this issue
@Progi1984
Copy link
Member

@jurchiks This issue has been fixed by a maintainer. You can help him by sponsoring him through Github sponsors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants