Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isKey #74

Closed
2 tasks
lishaduck opened this issue Oct 20, 2024 · 0 comments · Fixed by #77
Closed
2 tasks

Remove isKey #74

lishaduck opened this issue Oct 20, 2024 · 0 comments · Fixed by #77
Assignees
@lishaduck
Labels
good-first-issue Good for newcomers

Comments

@lishaduck
Copy link
Member

Explanation

It's not sound: microsoft/TypeScript#58877.
Just use @ts-expect-error until microsoft/TypeScript#44253 is resolved.

Steps

  • Inline it
  • Add @ts-expect-errors
@lishaduck lishaduck added the good-first-issue Good for newcomers label Oct 20, 2024
@lishaduck lishaduck linked a pull request Oct 20, 2024 that will close this issue
Misc #77
Merged
6 tasks
@lishaduck lishaduck moved this from Todo to Done in @lishaduck's todo list Oct 23, 2024
@lishaduck lishaduck self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lishaduck lishaduck

Labels
good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc PHS-TSA/webmaster-23-24
1 participant
@lishaduck