New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize _rotate_basis_state #103

Open

emerali opened this issue Dec 31, 2019 · 1 comment

Assignees

Labels

enhancement gpu Priority: Low Size: Medium

Collaborator

emerali commented Dec 31, 2019 •

edited

Loading

Create cplx-torch version of np.prod to speed up GPU run-time
Low prio: turn it into a generator function in order to be able to deal with a larger number of local rotations

emerali added enhancement Size: Medium Priority: Medium gpu labels

emerali added this to the Release v1.3 milestone

emerali self-assigned this

emerali added Priority: Low and removed Priority: Medium labels

Collaborator Author

emerali commented Dec 31, 2019

Tried creating a cplx-torch version of np.prod, didn't actually improve GPU performance (in fact it made it slightly slower)

Implementation of cplx.prod was as so:

Calculate arg of every element and add them up
Calculate magnitude and multiply them
Create complex result using magnitude and arg

There may be a better way to implement it, so I'll leave this issue open for now

emerali removed this from the Release v1.3 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment