Replies: 2 comments
-
Thank you for your contribution! I'll be meticulously reviewing your work over the next few days and will discuss any points with you as needed. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Your contributions have been successfully merged into the main branch. Thank you for your meticulous observation, outstanding code quality, and comprehensive tests. Reading your code convinced me that you have a deep understanding of our library, and this feature will significantly enhance the user experience for many. Additionally, I apologize for the delayed merge. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Following up on the PR #100. I additionally propose to make the following changes:
Goal0
,Goal1
andGoal2
etc (all the navigation tasks) with the config dictionaries.Builder
class.config
dictionary for all tasks in the navigation environments. This will simplify the environment creation process in theBuilder
class, i.e., there will be no need for theget_task_class_name
method. This will also potentially allow to register just one base environment for customization streamlining the process. The code will bePlease let me know if this is aligned with the library development and makes sense to implement
Beta Was this translation helpful? Give feedback.
All reactions