-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): 在适配器为 K8S 的时候,提交作业页面增加输入框:镜像地址 #954
Conversation
🦋 Changeset detectedLatest commit: 3469a33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 134 134
Lines 4005 4005
Branches 539 539
=======================================
Hits 2732 2732
Misses 1172 1172
Partials 101 101 ☔ View full report in Codecov by Sentry. |
protos/portal/job.proto
Outdated
@@ -151,6 +151,7 @@ message SubmitJobRequest { | |||
optional string memory = 15; | |||
optional string comment = 16; | |||
bool save_as_template = 17; | |||
optional string extra_options = 18; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra_options需要留有扩展性,应该是map<string, string>用来存放更多的数据
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
适配器那边的接口,使用的是 repeated string extra_options = 15; 我将proto/portal/job.proto也与其统一,改为string[]
后续如果有必要,把extra_options改成map<string, string>的字段,同时修改SCOW API。 |
我把把extra_options改成map<string, string>的字段,因为需要记录到模板中。适配器那边暂时不动。 |
配置:
若K8S设置为true,则在页面中展示: