Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCC network spacing is incorrect #2847

Closed
mkaguer opened this issue Oct 26, 2023 · 0 comments · Fixed by #2848
Closed

BCC network spacing is incorrect #2847

mkaguer opened this issue Oct 26, 2023 · 0 comments · Fixed by #2848
Labels

Comments

@mkaguer
Copy link
Contributor

mkaguer commented Oct 26, 2023

Here is a script that reproduces the bug. The problem is that the spacing returned is 1e-10 when I specified 1e-5. The issue is with line 72 of _bcc.py file. It multiplies the current spacing by the spacing, not realizing that the spacing was already applied correctly on line 50 above. I am making a PR.

import openpnm as op

# make BCC network
spacing = 1e-5
net = op.network.BodyCenteredCubic([5, 3, 3], spacing=spacing)

print(net['pore.coords'])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant