Do not validate the geo code on our side. Closes #377. Closes #364. C… #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you good with that @eddelbuettel ? |
|
Kinda sorta yes. It's a tricky question: not checking is bad, checking with a reg.exp may not catch all. Probably best to proceed. |
eddelbuettel
approved these changes
Apr 19, 2021
|
Meanwhile, I will continue the quest to find an "official" list or maybe find a way to use a GET to test the code before the actual query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very difficult to obtain a curated list of the full Google
geocodes. I suggest using a simple regex to parse thegeocode to check if the structure is valid. If the user uses an invalid scheme code,gtrends()will simply return an error.