Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'encoding = "UTF-8"' to read.csv calls (closes #299) #394

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add 'encoding = "UTF-8"' to read.csv calls (closes #299) #394

merged 1 commit into from
Jun 10, 2021

Conversation

eddelbuettel
Copy link
Collaborator

This simple PR implements what was suggested in #199, and seems to still behave in my tests and in CI.

@PMassicotte PMassicotte merged commit c4eabc7 into master Jun 10, 2021
@PMassicotte
Copy link
Owner

Thank you sir!

@PMassicotte PMassicotte deleted the feature/utf8 branch June 10, 2021 10:47
PMassicotte
PMassicotte reviewed Jun 10, 2021
View reviewed changes
Copy link
Owner

@PMassicotte PMassicotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@eddelbuettel
Copy link
Collaborator Author

eddelbuettel commented Jun 10, 2021 •
edited
Loading

I referenced #199 when I meant to reference #299. Whoops.

@eddelbuettel eddelbuettel changed the title Add 'encoding = "UTF-8"' to read.csv calls (closes #199) Add 'encoding = "UTF-8"' to read.csv calls (closes #299) Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PMassicotte PMassicotte PMassicotte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @PMassicotte