Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 2 support #16

Open
mratsim opened this issue Apr 20, 2019 · 1 comment
Open

Protobuf 2 support #16

mratsim opened this issue Apr 20, 2019 · 1 comment

Comments

@mratsim
Copy link

mratsim commented Apr 20, 2019

The README specifies proto3 at the moment but does not say if proto2 will also be a target in the future.

So is it? Will you accept PR to extend to proto2?

@PMunch
Copy link
Owner

PMunch commented Apr 24, 2019

I'm not planning on writing proto2 support myself, but if anyone else wants to add proto2 support (and maintain it) I'd be all for it. IIRC the reason I went with just proto3 is because it was easier to parse. The current parser should support parsing it, but if you want you can rewrite the whole parser part, it is slow and breaks on larger files due to the recursion limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants