Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support maps. #21

Open
kayabaNerve opened this issue Jul 28, 2020 · 2 comments
Open

Doesn't support maps. #21

kayabaNerve opened this issue Jul 28, 2020 · 2 comments

Comments

@kayabaNerve
Copy link

message ResultMap {
  map<string, Result> results = 3;
}

throws an error when being parsed. As this is syntactic sugar for:

message MapFieldEntry {
  key_type key = 1;
  value_type value = 2;
}

repeated MapFieldEntry map_field = N;

this isn't that big of a deal. That said, it is part of the Protobuf 3 spec.

@PMunch
Copy link
Owner

PMunch commented Aug 3, 2020

I know. To speed up development of the library I opted to not implement maps as they can be defined by a normal message as you pointed out. I'm more than happy to accept a PR though for an implementation of it if I don't find the time to implement it myself at some point.

@kayabaNerve
Copy link
Author

Yep. I'm actually planning on submitting some improvements soon. I not only wanted to track this, but also check with you on it. Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants