Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change License URLs from http:// to https:// #82

Closed
jpstotz opened this issue Jul 4, 2017 · 4 comments
Closed

Change License URLs from http:// to https:// #82

jpstotz opened this issue Jul 4, 2017 · 4 comments

Comments

@jpstotz
Copy link

jpstotz commented Jul 4, 2017

I noticed that all the license implementations in de.psdev.licensesdialog.licenses return the insecure http:// urls when calling getUrl().
From my perspective the urls should be changed to https:// as all the major version provider like Mozilla, Eclipse, Apache, ... have changed their primary site to https:// - therefore IMHO the urls in this library should be adapted, too.
@jpstotz
Copy link
Author

jpstotz commented Jul 4, 2017

Addendum: This also applies to the psdev url in class de.psdev.licensesdialog.LicensesDialog
new Notice("LicensesDialog", "http://psdev.de/LicensesDialog", ...

@hameno
Copy link
Member

hameno commented Jul 4, 2017

Good Idea, would you be willing to create a Pull Request?

@jpstotz
Copy link
Author

jpstotz commented Jul 5, 2017

Sorry I can't do that.

@hameno hameno closed this as completed in e781579 Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hameno @jpstotz and others