Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way for different styled badges #705

Closed
ricardoboss opened this issue Jan 22, 2022 · 17 comments
Closed

Add a way for different styled badges #705

ricardoboss opened this issue Jan 22, 2022 · 17 comments

Comments

@ricardoboss
Copy link
Collaborator

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

I'd like to be able to specify different styles for badges, namely plastic, flat, flat-squared and (maybe) for-the-badge.

style example
plastic image
flat image
flat-squared image
for-the-badge image

I think some are already possible, but it's not documented anywhere and I was unable to find any through trial and error. What do you think?

@JellyBellyDev
Copy link
Member

I also remember this feature in previous versions. I'm afraid we lost them with the 3.0 upgrade.
Would you like to try to restore them?

@ricardoboss
Copy link
Collaborator Author

Yes, I can dig into this and try to restore them. If I run into problems I'll ping you here, ok?

@JellyBellyDev
Copy link
Member

Of course! Thanks so much! 😎

@JellyBellyDev
Copy link
Member

Tips

@ricardoboss
Copy link
Collaborator Author

@JellyBellyDev everything done. I suppose I will need to update some docs as well.

@JellyBellyDev
Copy link
Member

Assume well! ;)
#707 (comment)

@ricardoboss
Copy link
Collaborator Author

Another possible solution if the data is available in JSON: shields.io

@JellyBellyDev
Copy link
Member

I would prefer not to make our product dependent on an additional external service (shields.io)...

@ricardoboss
Copy link
Collaborator Author

No, I meant not as an alternative renderer, but rather as an alternative to badge-poser.

@JellyBellyDev
Copy link
Member

So would you like to throw all this good work you've done in the trash?

@ricardoboss
Copy link
Collaborator Author

No of course not, but future visitors might want to consider alternatives.

@JellyBellyDev
Copy link
Member

I'm sorry but I'm not understanding. What are you proposing to do? :)

@ricardoboss
Copy link
Collaborator Author

ricardoboss commented Feb 14, 2022

I'm not proposing anything. I just wanted to tell future visitors of this issue (maybe found via Google) that there may be no need to use badge-poser if you have all information you want to display on your badge available via JSON.

This applied to my use-case, so I no longer need to use badge-poser and this issue is no longer my issue. I will of course still work on my PRs to fix this issue for everyone not being able to use shields.io.

@JellyBellyDev
Copy link
Member

Ok, now it's all clear to me. Thank you

@ricardoboss
Copy link
Collaborator Author

Waiting for badges/poser#89 to get merged so a new version of it can be released. Once that happened, I can update and merge #733 to fix this issue :)

@JellyBellyDev
Copy link
Member

Hey @ricardoboss, you are online! 🚀

@ricardoboss
Copy link
Collaborator Author

Thank you @JellyBellyDev for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants