Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKF2_AID_MASK: rotate external vision in 1.7.3 #9000

Closed
Changliu52 opened this issue Mar 2, 2018 · 5 comments
Closed

EKF2_AID_MASK: rotate external vision in 1.7.3 #9000

Changliu52 opened this issue Mar 2, 2018 · 5 comments

Comments

@Changliu52
Copy link

Changliu52 commented Mar 2, 2018

Hello,

Just want to ask for some information about the newly added option rotate_external_vision(6) for EKF2_AID_MASK.
I wonder if I have a SLAM measurement in NED, but not in true-north, do I need to enable this? and automatically getting the position in true-north by fusing the magnetometer?

If that is the case, will it be problematic if I also enable vision_yaw_fusion (4)? Since from what I understand, enabling vision_yaw_fusion will disable magnetometer fusion.

If that is not the case, what is the purpose rotate_external_vision option?

Thank you in advance.

Chang

@Changliu52
Copy link
Author

hello?

@mhkabir
Copy link
Member

mhkabir commented Mar 6, 2018

You cannot enable both fusion flags at once. They are mutually exclusively in the current implementation. Enabling rotate_external_vision will estimate the offset between the vision frame and true NED. The position estimate will be in true NED. The EKF thus keeps using the compass for yaw estimation, and this is not ideal, but we are working on a better solution.

@dagar
Copy link
Member

dagar commented Mar 6, 2018

Do we need an additional metadata mechanism to explicitly block invalid combinations? The other quick thing we could do is put a check in EKF2 updateParams() to log an error.

@Changliu52
Copy link
Author

Thank you for the clarification @mhkabir.
Great! That's one step forward! Despite the magnetic interference, at least we can always fuse GPS + Vision together! (that is what's happening when enables use_GPS + vision_position_fusion + rotate_external_vision, right?)

Great work!

@mhkabir
Copy link
Member

mhkabir commented Mar 7, 2018

@Changliu52 Yes!

@dagar Definitely need some metadata there to block that specific combo (for now at-least, till we can get them both working in tandem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants