Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename src/drivers/adc to src/drivers/adc/arch_adc #14477

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Rename src/drivers/adc to src/drivers/adc/arch_adc #14477

merged 3 commits into from
Sep 8, 2020

Conversation

SalimTerryLi
Copy link
Contributor

@SalimTerryLi SalimTerryLi commented Mar 25, 2020 •
edited
Loading

Describe problem solved by this pull request
Rename src/drivers/adc to src/drivers/adc/arch_adc

#14437

@TSC21 TSC21 requested a review from dagar April 4, 2020 07:47
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jul 3, 2020
@bys1123
Copy link
Contributor

bys1123 commented Jul 3, 2020

@davids5 @dagar

@stale stale bot removed the stale label Jul 3, 2020
@davids5
Copy link
Member

davids5 commented Jul 3, 2020

@SalimTerryLi Where is the name an issue? Would calling something new offboard_adc solve the same isuue?

@SalimTerryLi
Copy link
Contributor Author

@SalimTerryLi Where is the name an issue? Would calling something new offboard_adc solve the same isuue?

Ohh... Maybe "on-chip" sounds better...
Currently I'm preparing my new hardware-design and, will resume working on software side in a week...

@weekly-digest weekly-digest bot mentioned this pull request Jul 5, 2020
Closed
@SalimTerryLi SalimTerryLi changed the title Rename src/drivers/adc to src/drivers/adc/onboard_adc Rename src/drivers/adc to src/drivers/adc/arch_adc Sep 6, 2020
@SalimTerryLi
Copy link
Contributor Author

@dagar Here

@SalimTerryLi SalimTerryLi mentioned this pull request Sep 7, 2020
Merged
@dagar
Copy link
Member

dagar commented Sep 7, 2020

Not that I like debating naming, but I don't think arch_adc is quite right because it's very specifically not the architecture specific part of the ADC.

How about something like board_adc?

@dagar dagar mentioned this pull request Sep 7, 2020
Merged
@SalimTerryLi
Copy link
Contributor Author

Not that I like debating naming, but I don't think arch_adc is quite right because it's very specifically not the architecture specific part of the ADC.

How about something like board_adc?

Done.

@dagar
Copy link
Member

dagar commented Sep 8, 2020

Thanks @SalimTerryLi, I appreciate your persistence.

@dagar dagar merged commit c037dbe into PX4:master Sep 8, 2020
@SalimTerryLi SalimTerryLi deleted the pr-rename_drivers_adc branch April 24, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar approved these changes

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡 Drivers 🔧 Sensors, Actuators, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SalimTerryLi @bys1123 @davids5 @dagar