Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: drivers/uavcan: add locking for command line param helpers #14741

Closed
wants to merge 1 commit into from
Closed

[WIP]: drivers/uavcan: add locking for command line param helpers #14741

wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Apr 23, 2020

Untested potential quick fix for #14736.

@dagar dagar mentioned this pull request Apr 23, 2020
Closed
@dagar dagar added this to the Release v1.11.0 milestone Apr 23, 2020
@JacobCrabill
Copy link
Member

Makes sense to me. Unfortunately I won't have access to hardware for a few days; I'll be able to test on Monday if no one gets to this sooner.

@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@JacobCrabill
Copy link
Member

Tried testing this, and all I'm getting is just a continuous stream of baro errors:
image

@JacobCrabill
Copy link
Member

I can't even use QGC because of the continuous stream of MAVLink error messages...

@JacobCrabill
Copy link
Member

I did however also test this patch on a custom version of PX4 based off of v1.10.0, and although the sensor_baro issues are not present, the hardfault still occurs, though perhaps slightly less frequently.

Also, sometimes instead of a hardfault, I instead get the error where all PX4 commands are no longer found (i.e. top: command not found)

@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2020
@dagar dagar closed this Nov 23, 2020
@LorenzMeier LorenzMeier deleted the pr-uavcan_param_locking branch January 18, 2021 14:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug stale UAVCAN
Projects
None yet
Milestone
Release v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @JacobCrabill