Bug fix in gazebo_sitl_multiple_run.sh #15392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change location of where PX4_SIM_MODEL is set to avoid mixer issues. Before, the change px4 would start all models as `iris` whilst gazebo was spawning in the correct meshes. This resulted in both `plane` and `standard_vtol` running with the `quad_w` mixer.
|
@iwishiwasaneagle do you want to include any of the files from our slack convo (one that I found mixer issue in) and then another one showing the correct vehicle rcS/mixer after the fix? Makes it easier for people to understand the issue. |
|
Jaeyoung-Lim
requested changes
Jul 22, 2020
Jaeyoung-Lim
requested changes
Jul 22, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Change location of where
$PX4_SIM_MODELis set to avoid mixer issues. Before, the change px4 would start all models asiriswhilst gazebo was spawning in the correct meshes. This resulted in bothplaneandstandard_vtolrunning with thequad_wmixer.Describe your solution
Define
$PX4_SIM_MODELwithinspawn_model()based on$MODEL, so that when-sis used the correct targets are used.Tests
-s plane:1,iris:1- spawns 1 plane, 1 iris-m iris -n 3- spawns 3 iris-n 3-> spawns 3 iris