logger: Add logging profile to support comparison of multiple sensors #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Oct 16, 2017
src/modules/logger/logger.cpp
Outdated
| @@ -624,6 +624,14 @@ void Logger::add_thermal_calibration_topics() | |||
| add_topic("sensor_gyro", 100); | |||
| } | |||
|
|
|||
| void Logger::add_sensor_comparison_topics() | |||
| { | |||
| add_topic("sensor_accel", 10); | |||
There was a problem hiding this comment.
Just to clarify: 10 is the interval in ms, not Hz. Is that your intention?
There was a problem hiding this comment.
No it wasn't, i will change it to 100.
10Hz was the intended rate
bkueng
approved these changes
Oct 16, 2017
|
@priseborough CI failed because of flash overflow. Can you please rebase to master? |
|
OK |
dagar
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to assist users with diagnosing pre-arm sensor consistency failures.