To include timestamp field in the micrortps bridge messages. #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Feb 15, 2018
| @@ -151,6 +147,7 @@ void serialize_@(topic_name)(const struct @(uorb_struct) *input, char *output, u | |||
|
|
|||
| resetStaticMicroCDRForSerialize(microCDRWriter); | |||
|
|
|||
| serializeUnsignedLong(input->timestamp, microCDRWriter); | |||
There was a problem hiding this comment.
Should this not be serializeUnsignedLongLong?
There was a problem hiding this comment.
No, is the correct one. Please, see the function prototype
There was a problem hiding this comment.
But then https://github.com/PX4/Firmware/pull/8888/files#diff-8190543ff07160bad612518e04f0e097R73 should be uint64_t
There was a problem hiding this comment.
No, there is no uint64_t type in IDL
There was a problem hiding this comment.
Ah, I see, that's IDL. You're right then.
bkueng
approved these changes
Feb 15, 2018
|
@avinash-palleti and I have already tested this. |
LorenzMeier
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under petition of community and particularly of @avinash-palleti (Intel). @bkueng