Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr tiltrotor sim #8936

Merged
merged 8 commits into from
Feb 22, 2018
Merged

Pr tiltrotor sim #8936

merged 8 commits into from
Feb 22, 2018

Conversation

RomanBapst
Copy link
Contributor

This brings in support for a quad tiltrotor in gazebo.
The model works, it needs a review and more testing.

@RomanBapst RomanBapst changed the title [WIP] Pr tiltrotor sim Pr tiltrotor sim Feb 22, 2018
@RomanBapst RomanBapst force-pushed the pr-tiltrotor-sim branch 2 times, most recently from 07e05c0 to 4c2f0fb Compare February 22, 2018 15:53
Mixer for quad tiltrotor (x motor configuration)
================================================

This file defines a single mixer for a tiltrotor (SITL gazebo) with motors in X configuration. The plane has two ailerons and one elevator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add as a generic tiltrotor mixer?

@dagar
Copy link
Member

dagar commented Feb 22, 2018

@PX4BuildBot rebase

LorenzMeier
LorenzMeier previously approved these changes Feb 22, 2018
@PX4 PX4 deleted a comment from PX4BuildBot Feb 22, 2018
@PX4 PX4 deleted a comment from PX4BuildBot Feb 22, 2018
@dagar
Copy link
Member

dagar commented Feb 22, 2018

CI was full, rebasing again to kick it off. @PX4BuildBot rebase

@PX4BuildBot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@PX4BuildBot
Copy link
Collaborator

Automated rebase with GitMate.io was successful! 🎉

@dagar
Copy link
Member

dagar commented Feb 22, 2018

@RomanBapst CI style failure. http://ci.px4.io:8080/blue/organizations/jenkins/Firmware/detail/PR-8936/1/pipeline/720

Locally you can install astyle and run make check_format or make format.

image

Signed-off-by: Roman <bapstroman@gmail.com>
- increased the number of pwm outputs
- handle PWM_SERVO_SET_MIN_PWM and PWM_SERVO_SET_MAX_PWM

Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
@RomanBapst
Copy link
Contributor Author

@dagar Thanks! I fixed code style and added a pre-commit hook.

@dagar dagar merged commit 2549b70 into master Feb 22, 2018
@dagar dagar deleted the pr-tiltrotor-sim branch February 22, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants