Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: convert missions to QGC plan format #8982

Merged
merged 6 commits into from
Mar 1, 2018

Conversation

lamping7
Copy link
Member

@dagar Do we want to modify/remove vtol_old_3? It was failing CI because the mission doesn't include landing, preventing the current sequence from resetting to 0. I've fixed how the end of the mission is detected, but now, because there is not another mission item, the vehicle begins to steer away from the WP, to loiter around it, causing a "yaw error mean" failure in the post mission check. What makes this mission different from the others is that it uses MAV_CMD_NAV_WAYPOINT to takeoff and goto the first WP.

@lamping7
Copy link
Member Author

I added the mission descriptions here: #8915

Also, If we can now assume that all missions will have a .plan file extension, I can remove the hack in the Jenkinsfile that renames the XML test result files.

@dagar dagar self-requested a review March 1, 2018 05:47
@dagar
Copy link
Member

dagar commented Mar 1, 2018

Yes let's assume it's .plan only from this point on.

@lamping7
Copy link
Member Author

lamping7 commented Mar 1, 2018

If this looks good to you I'll squash it and we can continue to iterate over: #8887, #8799, and #8915

@dagar
Copy link
Member

dagar commented Mar 1, 2018

Thanks, this is much better.

@dagar dagar merged commit 1ef7b35 into PX4:master Mar 1, 2018
@dagar
Copy link
Member

dagar commented Mar 1, 2018

Thanks, this is much better.

@lamping7 lamping7 deleted the pr-ci_mission_tests branch March 2, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants