FW landing project virtual waypoint to handle landing overshoot #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No obvious regressions in a simple landing test. https://logs.px4.io/plot_app?log=96425379-31f7-46a9-9506-5f7f455c7057 |
|
Here's one where I set the landing angle unrealistically high.
|
|
@dagar Will review this tomorrow morning! |
RomanBapst
approved these changes
Mar 14, 2018
|
@dagar Have you ever thought of splitting this up into several files? |
|
Not really, but that might help. I feel like a lot of it could probably be condensed a lot better. For example when handling the manual position mode we could be first generating the setpoint, then going through the exact same control_position code as regular navigation. Likewise for takeoff after altitude/airspeed is achieved and several other cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.