convergence config: increase idle speed in mc mode #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this makes sure that all motors are idling in mc mode. having this too low can lead to a motor stopping in flight which is critical for attitude control - experienced loss of attitude control in RTL during descent prior to this change Signed-off-by: Roman <bapstroman@gmail.com>
|
Why can't we use regular PWM min and get rid of this parameter? |
|
Worth merging immediately, but I'd still like to take a step back to review the need for these special VTOL parameters that are already configurable by other means. @bresch FYI |
dagar
approved these changes
Mar 5, 2018
|
Follow up PR related to how we handle PWM min, max, disarmed in VTOL. #9028 |
|
@dagar The only motivation I can see for this parameter is that fact that you might not want to have the same idle in fw as in mc mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
low can lead to a motor stopping in flight which is critical for
attitude control
change
Signed-off-by: Roman bapstroman@gmail.com