-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc.sensors : fix startup for lidars on Pixhawk boards #9058
Conversation
Add the full range? |
@dagar Added v4PRO. Others don't seem to expose Serial4 and/or have no documentation about UART to port mappings. |
I believed that you're using the port meant for FrSky telemetry. I'm not fully sure, but I believe that it has some additional hardware on the port specifically needed for the FrSky telemetry. This is probably the reason for the failures. |
@Antiheavy yep. Just checked. It has an inverter on it. |
@mhkabir thanks for checking that, however, the FMUv4 hardware we are using is slightly different than Pixracer. On our board this port does not have the inverter on it; it has the Rx/Tx traces from the STM32 PE0 and PE1 pins running straight out to a connector. Is there anything in the firmware that prevents us from using this port for a TFmini (or generically for anything else)? |
Hmm alright. I think you should be fine in that case, from a software perspective. I don't have any better insights at this point without actually debugging on the hardware. |
@mhkabir okay thanks for checking. |
@dagar Good to merge? |
I thought there would be more, but let's go with this for now. |
The check was not changed back to PX4FMU_V2 after we merged V3 and V2 configs.
This is a hotfix till we actually properly structure this whole sensors startup mess. This current way does not scale well as we add new boards and/or drivers.