-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
px4fmu v2 sensor init (again) and cleanup #9074
Conversation
- if an invalid version is detected reinit, then reset
@svpcom please test and review. |
I changed the default (fallback) behaviour to match what the stock px4fmu-v2 did historically. I believe the pixhack v3 issue is unrelated, and we simply need to determine what's actually on that board and fit it into the fmu-v2 binary (old bootloader again). I haven't been able to find a good schematic online yet. |
Any other scenarios worth testing? |
@dagar None that I could think of. |
@dagar It works for me. Have you any plans to backport it to 1.7.x ? |
I'll bring that up on the dev call. Either doing a v1.7.4 point release with a handful of cherry-picked fixes, or releasing master as v1.8.0 soon. |
This is similar to the fix @svpcom implemented in #8703, except instead of forcing to FMU-v2 in a particular error case this PR defaults to treating the board like a traditional FMU-v2 in all cases where a cube or pixhawk mini aren't detected.
I also dropped the BOARD_HAS_SIMPLE_HW_VERSIONING defines because we don't have a build with that disabled.
Checking sensors status for each board. Pass means all expected onboard sensors found.