mathlib Limits move radians/degrees to template header #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-mathlib_limits
branch
from
193ef02
to
6dd9b97
Compare
bkueng
reviewed
Mar 19, 2018
src/lib/mathlib/math/Limits.hpp
Outdated
| template<typename T> | ||
| constexpr T radians(const T degrees) | ||
| { | ||
| return (degrees / static_cast<T>(180)) * static_cast<T>(M_PI); |
There was a problem hiding this comment.
Can you change the bracketing, so that the compiler can reduce it to a single multiplication?
degrees * (static_cast<T>(M_PI) / static_cast<T>(180))
dagar
force-pushed
the
pr-mathlib_limits
branch
from
6dd9b97
to
fb0aeeb
Compare
bkueng
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.