Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers: Add TeraRanger Evo 600Hz support #9169

Merged
merged 3 commits into from
Apr 4, 2018

Conversation

msadowski
Copy link
Contributor

@msadowski msadowski commented Mar 27, 2018

Hi!

We are soon launching a new TeraRanger Evo sensor (Evo 600Hz) and we thought it is a good idea to create a new option for SENS_EN_TRANGER that will correctly represent the minimum and maximum distance of this new sensor.

We also renamed the previous option to TREvo60m (previously just Evo).

If there is anything else you wold like us to update please don't hesitate to ask and someone from our team will work on it.

@ndepal
Copy link
Contributor

ndepal commented Mar 27, 2018

Nice!

The new Evo has the same I2C address as the existing one, correct? This breaks the auto-detection of which TeraRanger is connected.

We should either remove the auto-detection or document that it will always assume the 60m Evo.

@msadowski
Copy link
Contributor Author

@ndepal that's correct, the addresses and whoami's will be the same for all sensors in Evo family.

How important are the minimum and maximum ranges from the flight control perspective? We were hoping that for users that are likely to test multiple sensors we could leave autodetection that provides minimum and maximum distances across the whole Evo family of sensors (e.g. 0.1-60m). I'm more than happy to document this functionality if that's something we want.

@hamishwillee
Copy link
Contributor

It would be great if we could update the docs: https://docs.px4.io/en/sensor/rangefinders.html#teraranger-one

Also excellent if the driver could get some in-source docs that can are generated here - you can see how this is done in the Module Template and in the GPS driver here:
https://github.com/PX4/Firmware/blob/03b8cd78b3e32be581f5e9ecf22358da03b3fe91/src/drivers/gps/gps.cpp#L943

@dagar
Copy link
Member

dagar commented Apr 4, 2018

@msadowski auto-detection sounds interesting. Were you thinking an additional parameter to enable it?

@dagar dagar merged commit f0a8569 into PX4:master Apr 4, 2018
@dagar
Copy link
Member

dagar commented Apr 4, 2018

Base driver changes look good. We can do another PR to if for module documentation.

@msadowski
Copy link
Contributor Author

@dagar Thanks for the merge! I don't know if understood your comment on auto-detection. What kind of parameter do you have in mind? There is already an Autodetect parameter in SENS_EN_TRANGER.

@dagar
Copy link
Member

dagar commented Apr 4, 2018

Ah, I didn't see the existing autodetection option.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants