Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete mathlib Vector/Matrix #9181

Merged
merged 2 commits into from
May 23, 2018
Merged

delete mathlib Vector/Matrix #9181

merged 2 commits into from
May 23, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 28, 2018 •
edited by AuterionWrikeBot
Loading

No description provided.

This was referenced Mar 28, 2018
Closed
Merged
@dagar
Copy link
Member Author

dagar commented Mar 28, 2018

Ran full calibration and compared parameters before and after. No significant differences. Commander didn't require any additional stack either.

@dagar dagar requested a review from a team March 28, 2018 22:42
@dagar
Copy link
Member Author

dagar commented Mar 28, 2018 •
edited
Loading

@PX4/testflights on a couple random boards (fmu-v2, fmu-v4, etc) could you please do some basic bench testing with this branch? Save your parameters from before (master baseline) and after a full calibration on this branch and we'll compare them.

Also enable logging from boot so we can check stack and cpu usage.

@dagar dagar requested a review from bkueng March 28, 2018 22:47
@santiago3dr
Copy link

Pixracer (V4)
fresh flash with master d40d165
reset all parameters to default and ran full setup
master.txt

Flashed this PR
reset all parameters to default and ran full setup

Mag calibration just hangs and does not complete; after waiting a few minutes, qgc flagges the fc as disconnected
stuck calibration

These are the parameters with setup until getting stuck at mag calibration
pr_9181.txt

@dagar
Copy link
Member Author

dagar commented Mar 28, 2018

Definitely need more stack for the mag cal routine.

@dagar dagar changed the title delete mathlib Vector/Matrix [WIP] delete mathlib Vector/Matrix Mar 28, 2018
@dagar dagar force-pushed the pr-mathlib_matrix_delete branch 2 times, most recently from bc19432 to c3278d5 Compare April 1, 2018 19:19
@jgoppert
Copy link
Member

jgoppert commented Apr 5, 2018

I'm looking forward to seeing this merged.

@dagar dagar force-pushed the pr-mathlib_matrix_delete branch from c3278d5 to a6c6ca6 Compare May 15, 2018 17:46
@dagar dagar force-pushed the pr-mathlib_matrix_delete branch from a6c6ca6 to fb6e85b Compare May 17, 2018 23:32
@dagar dagar force-pushed the pr-mathlib_matrix_delete branch from fb6e85b to eae79d7 Compare May 17, 2018 23:36
@dagar dagar changed the title [WIP] delete mathlib Vector/Matrix delete mathlib Vector/Matrix May 17, 2018
@dagar
Copy link
Member Author

dagar commented May 17, 2018

We can keep the mat_inverse for now and still get rid of the rest.

@dagar dagar added this to the Release v1.8.0 milestone May 17, 2018
@LorenzMeier
Copy link
Member

@dagar @RomanBapst We need to make sure to bring the Snapdragon fixes onto master and test this rebased onto them.

@dagar
Copy link
Member Author

dagar commented May 23, 2018

Rebased on master (with snapdragon fixes). Tested snapdragon basic usage and full recalibration of a pixracer.

@dagar dagar merged commit 222a91c into master May 23, 2018
@dagar dagar deleted the pr-mathlib_matrix_delete branch May 23, 2018 21:27
@mrpollo mrpollo mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

@jgoppert jgoppert Awaiting requested review from jgoppert

@MaEtUgR MaEtUgR Awaiting requested review from MaEtUgR

@bkueng bkueng Awaiting requested review from bkueng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dagar @santiago3dr @jgoppert @LorenzMeier