Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap_esc cleanup - addendum #9356

Merged
merged 4 commits into from
Apr 23, 2018
Merged

tap_esc cleanup - addendum #9356

merged 4 commits into from
Apr 23, 2018

Conversation

potaito
Copy link
Contributor

@potaito potaito commented Apr 23, 2018 •
edited by AuterionWrikeBot
Loading

There are a few minor things I forgot to add to the previous cleanup PR: #9313

@bkueng Could you take another look? Should be an easy PR :) Sorry for the hassle.

@potaito potaito self-assigned this Apr 23, 2018
@potaito potaito requested a review from bkueng April 23, 2018 08:23
@potaito potaito force-pushed the pr-tap-esc-cleanup-addendum branch from 1c946ca to 6914296 Compare April 23, 2018 08:29
bkueng
bkueng approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bkueng bkueng merged commit 255cc12 into master Apr 23, 2018
@bkueng bkueng deleted the pr-tap-esc-cleanup-addendum branch April 23, 2018 10:08
@mrpollo mrpollo mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees

@potaito potaito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potaito @bkueng