ecl ekf tools: code refactoring to separate visualization from analysis #9377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move code that is needed for general analysis out of plot scope
…ocessing - move the analysis parts of the process_logdata_ekf script to the 'analyse_ekf' function in a new file analyse_logdata_ekf.py - return a test_results dictionary from analyse_ekf - still process log loading, preprocessing and results file output in process_logdata_ekf - add command line argument to toggle plotting - add command line argument to use different dictionary to check_level_dict.csv
LorenzMeier
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the code of the ecl_ekf analysis tools to enabling running the analysis separately from the visualization and results output. The main functionality of the tool hasn't changed and it can still be run as before.