Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete srf02_i2c which is nearly identical to srf02 #9396

Merged
merged 1 commit into from
May 2, 2018
Merged

delete srf02_i2c which is nearly identical to srf02 #9396

merged 1 commit into from
May 2, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented May 2, 2018 •
edited by AuterionWrikeBot
Loading

No description provided.

@dagar
Copy link
Member Author

dagar commented May 2, 2018

Here's an 2.8 kilobytes of flash for v2.

@hamishwillee
Copy link
Contributor

Does this affect docs?
Specifically

  • is the parameter for enabling MaxBotix I2CXL-MaxSonar-EZ unchanged?
  • What else is Srf02 driver used for ... and does it change any of those other docs?

@dagar
Copy link
Member Author

dagar commented May 2, 2018 •
edited
Loading

@hamishwillee no this shouldn't change anything there. This is a weird case where we had an identical (nearly) srf02 driver named srf02_i2c.

@dagar dagar merged commit 598743b into master May 2, 2018
@dagar dagar deleted the pr-srf02_redundant branch May 2, 2018 12:50
@mrpollo mrpollo mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @hamishwillee