Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure Scan - Gimbal Orientation #9405

Merged
merged 1 commit into from
May 3, 2018
Merged

Structure Scan - Gimbal Orientation #9405

merged 1 commit into from
May 3, 2018

Conversation

mrivi
Copy link
Contributor

@mrivi mrivi commented May 3, 2018

I have tested the Structure Scan feature and the gimbal doesn't point perpendicularly to the heading.
The gimbal points to the next triplet with an offset of 90deg which is not the area of interest.
qgc

In order to have the gimbal pointing towards the structure when MIS_MNT_YAW_CTL =1, the gimbal has to point to the current triplet with an offset of 90deg.

@mrivi mrivi requested a review from bkueng May 3, 2018 13:59
@dagar
Copy link
Member

dagar commented May 3, 2018

I initially thought this was an ROI setting, but now I see it makes sense. Architecturally it would be better for navigator to be interpreting the ROI and sending gimbal commands (if appropriate), but this is good for now.

@dagar dagar merged commit 41b0db2 into master May 3, 2018
@dagar dagar deleted the pr-structure_scan branch May 3, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants