lis3mdl driver refactor #9448
Merged
lis3mdl driver refactor #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 4, 2018 09:11
|
@dagar, The refactoring work in Jake's pull request here is essentially a template we'd like to continue instituting in the other magnetometer drivers. The current lis3mdl driver copied/pasted a lot of irrelevant and dead code. We've effectively created a clean start to this driver and verified functionality. Let us know if you have feedback/questions. -Mark |
|
Thanks @mhkabir ! Also, just so anyone utilizing the lis3mdl is aware, the lis3mdl shows huge bias shifts with temperature changes and this is a known issue with the sensor: https://community.st.com/docs/DOC-1428-faq-lis3mdl-offset-thermal-drift -Mark |
|
P.S.anyone using the lis3mdl should aggressively move to switch away from that sensor! -Mark |
LorenzMeier
approved these changes
May 16, 2018
|
Looking good, thanks for helping to tidy up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did an overhaul of the structure and organization of this magnetometer driver. Fixed temperature calculations, increased data rate, and optimized device register values. Removed useless code (artifacts of copy/paste from previous drivers), standardized functions, and in general improved the readability of the driver.