Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMFS: fix SYS_USE_IO==0 #9551

Merged
merged 1 commit into from
May 28, 2018
Merged

ROMFS: fix SYS_USE_IO==0 #9551

merged 1 commit into from
May 28, 2018

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented May 28, 2018

When SYS_USE_IO was disabled, px4io would not start and thus there was no RC.
SYS_USE_IO=0 is interesting on Quads to avoid the IO and reduce output latency.

Tested on Pixhawk 1 and Pixhawk 4.

@mcsauder It will conflict with #9487, so not sure if we should directly go for #9487 and fix it there (due to indentation changes the diff here looks worse than it actually is).

When SYS_USE_IO was disabled, px4io would not start and thus there was no
RC. SYS_USE_IO=0 is interesting on Quads to avoid the IO and reduce output
latency.

Tested on Pixhawk 1 and Pixhawk 4
@mcsauder
Copy link
Contributor

Hi @bkueng. I like your changes here. That if statement has been bothering me as it seemed to be dead code in my refactor. I can patch up #9487 to mirror this PR, and I'd advocate for this PR to be accepted as quickly as it can be. Thanks for the note!

@LorenzMeier LorenzMeier merged commit 77cea88 into master May 28, 2018
@LorenzMeier LorenzMeier deleted the fix_sys_use_io branch May 28, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants