Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Quad+ toml file #8822

Closed
cglusky opened this issue Feb 4, 2018 · 5 comments
Closed

Typo in Quad+ toml file #8822

cglusky opened this issue Feb 4, 2018 · 5 comments
Labels
bug Documentation 📑 Anything improving the documentation of the code / ecosystem

Comments

@cglusky
Copy link
Contributor

cglusky commented Feb 4, 2018 •
edited by AuterionWrikeBot
Loading

Just reading through some of the new changes to the multi mixer files. Think this line is supposed to be read "rear"...

https://github.com/PX4/Firmware/blob/64f032441c3579d07287d5e3bac424dbf9d7ab4f/src/lib/mixer/geometries/quad_plus.toml#L28
@dagar
Copy link
Member

dagar commented Feb 4, 2018

Thanks Coby. Would you like to submit a PR fixing it?

@dagar dagar added bug Documentation 📑 Anything improving the documentation of the code / ecosystem labels Feb 4, 2018
@dagar dagar added this to the Release v1.8.0 milestone Feb 4, 2018
@cglusky
Copy link
Contributor Author

cglusky commented Feb 5, 2018

Yes, I can do that.

@cglusky cglusky mentioned this issue Mar 4, 2018
Merged
@dagar dagar removed this from the Release v1.8.0 milestone May 4, 2018
@stale
Copy link

stale bot commented Jan 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 11, 2019

Closing as stale.

@stale stale bot closed this as completed Feb 11, 2019
@dagar
Copy link
Member

dagar commented Feb 11, 2019

Fixed in #9008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Documentation 📑 Anything improving the documentation of the code / ecosystem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cglusky @dagar