Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console output on Mac OS #9495

Closed
LorenzMeier opened this issue May 21, 2018 · 3 comments
Closed

Console output on Mac OS #9495

LorenzMeier opened this issue May 21, 2018 · 3 comments
Assignees
Labels

Comments

@LorenzMeier
Copy link
Member

LorenzMeier commented May 21, 2018

@MaEtUgR M
FYI

Makefile colors do not work e.g. \033[0;34mFormatting with astyle \033[m
Certain terminal combinations like cygwin - mintty - xterm - bash do not escape colors by default.
Solution: Force interpretation of backslash escapes with the parameter -e of echo.

This change introduce a new issue in MacOS console:

bash-3.2$ make format
-e \033[0;94mFormatting with astyle \033[m

PR that introduces this: #9441 (comment)

@MaEtUgR
Copy link
Member

MaEtUgR commented May 28, 2018

Sorry for that side effect, I was testing all the systems available to me for this PR and was assuming the mac console would react similarly to linux which is obviously not the case. I'm willing to fix this but how can I test? Is there a way to reproduce on Windows/Linux? I know there are inofficial MacOS VMs but I try to avoid spending hours just to see the color and text of the output in the console.

EDIT: Maybe I could test on @julianoes's mac when he's back next week?

@LorenzMeier
Copy link
Member Author

Fixed!

@MaEtUgR
Copy link
Member

MaEtUgR commented May 29, 2018

@LorenzMeier ok, thanks. Would be interesting how, I don't see any change. Still glad the problem doesn't seem to persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants