Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate within PYPIT #26

Open
profxj opened this issue Nov 22, 2017 · 4 comments
Open

Integrate within PYPIT #26

profxj opened this issue Nov 22, 2017 · 4 comments

Comments

@profxj
Copy link
Contributor

profxj commented Nov 22, 2017

i.e. no longer as a separate Repo.

What do you think @rcooke-ast ?

Is it time now?

@rcooke-ast
Copy link
Contributor

Ahhh... I had no idea that this was a plan. I suppose it makes sense. It depends if you think it has some value outside of PYPIT. Do you have a preference?

@profxj
Copy link
Contributor Author

profxj commented Nov 24, 2017

Good point. It should have value outside PYPIT.
At least the arc line lists..

Closing

@profxj profxj closed this as completed Nov 24, 2017
@rcooke-ast rcooke-ast reopened this Dec 10, 2017
@rcooke-ast
Copy link
Contributor

Reopening this issue... If we make changes to arclines, it seems unreasonable to expect that people using PYPIT will know to update both packages. It seems sensible, therefore, to include the arclines code into PYPIT. What do you think, @profxj? I wouldn't object to including the arc line lists too, for the record.

@profxj
Copy link
Contributor Author

profxj commented May 2, 2018

I now agree. While I am going to merge #30
we will push arclines into PYPIT before long.

Maybe as a sub-package, if that is easy enough to
do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants