Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review gapd calculator #192

Open
5 tasks
CFGrote opened this issue Apr 28, 2020 · 3 comments
Open
5 tasks

Review gapd calculator #192

CFGrote opened this issue Apr 28, 2020 · 3 comments
Assignees
@JunCEEE

Comments

@CFGrote
Copy link
Collaborator

CFGrote commented Apr 28, 2020 •
edited

Hi Juncheng, very good work, just a few minor comments:

GAPDPhotonDiffractorParameters.py:

  • l 4ff: put yourself as 2nd author
  • l 37ff: check you really need all these parameters, do they make sense for GAPD?
  • 102-115: as discussed: remove these lines, align 116-126

GAPDPhotonDiffractorTest.py

  • l4f: add yourself as 2nd author

GAPDPhotonDiffractorParametersTest.py

  • l4f: add yourself as 2nd author

So far so good. I assume you will work on the GAPDPhotonDiffractor next?
@CFGrote
Copy link
Collaborator Author

CFGrote commented May 6, 2020

hi @ejcjason , any progress on this one?

@JunCEEE
Copy link
Collaborator

JunCEEE commented May 6, 2020

I am overwhelmed by the EMC analysis. I will finalize this on the weekend.

@JunCEEE
Copy link
Collaborator

JunCEEE commented May 12, 2020 •
edited

  • Monochromatic beam unittest
  • Polychromatic beam unittest
  • Temporal integration unitest
  • Read PMI output unittest
  • CXI hdf5 output unittest

@JunCEEE JunCEEE closed this as completed May 12, 2020
@JunCEEE JunCEEE reopened this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JunCEEE JunCEEE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JunCEEE @CFGrote