Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing only absolute paths for instrument_base_dir #71

Open
shervin86 opened this issue May 18, 2022 · 0 comments
Open

Storing only absolute paths for instrument_base_dir #71

shervin86 opened this issue May 18, 2022 · 0 comments

Comments

@shervin86
Copy link
Contributor

shervin86 commented May 18, 2022

In calculators there is a member storing the instrument_base_dir.
I think it would be more robust to store it always as an absolute path, even when the user sets it as relative to the current working directory. That would reduce the number of possible issues when paths or the current working directory is changed.
I would suggest to use in the setter

self._instrument_base_dir = os.path.abspath(value)

Then the calculator_base_dir will be relative to the instrument_base_dir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant