Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The model in test_machine_translation.py is not correct. #7012

Closed
lcy-seso opened this issue Dec 25, 2017 · 0 comments · Fixed by #7770
Closed

The model in test_machine_translation.py is not correct. #7012

lcy-seso opened this issue Dec 25, 2017 · 0 comments · Fixed by #7770
Assignees
Labels

Comments

@lcy-seso
Copy link
Contributor

lcy-seso commented Dec 25, 2017

This script is expected to implement the encoder-decoder without attention. , but it is not the conventional RNN encoder-decoder. See this paper for reference https://arxiv.org/pdf/1406.1078.pdf

image

In every time step, decoder takes the encoded vector as its input: https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/tests/book/test_machine_translation.py#L36

Also related to #7011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants