Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Add]Add forward analysis of control arm example #642

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

lijialin03
Copy link
Contributor

@lijialin03 lijialin03 commented Nov 15, 2023

PR types

Others

PR changes

Others

Describe

  1. add forward analysis of control arm example
  2. add freeze and unfreeze in arch.Arch

@HydrogenSulfate HydrogenSulfate changed the title [Add]Add forward analysis of control arm example [WIP][Add]Add forward analysis of control arm example Nov 15, 2023
@lijialin03 lijialin03 force-pushed the control_arm branch 2 times, most recently from f7225d9 to f90c3f6 Compare November 27, 2023 03:30
docs/zh/examples/control_arm.md Outdated Show resolved Hide resolved
docs/zh/examples/control_arm.md Outdated Show resolved Hide resolved
@HydrogenSulfate
Copy link
Collaborator

HydrogenSulfate commented Nov 28, 2023

arch.Arch 加一下 freezeunfreeze 方法(参考https://github.com/Lightning-AI/lightning/blob/197b22586a449fd24d6835c2b186d7900de05c93/src/lightning/pytorch/core/module.py#L1317-L1343),并用 model.freeze() 在逆问题中冻结掉另外两个模型,减少梯度反传时不必要的时间和显存开销。

ppsci/arch/base.py Outdated Show resolved Hide resolved
docs/zh/examples/control_arm.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit d021faa into PaddlePaddle:develop Nov 29, 2023
3 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* Add forward analysis of control arm example

* use x-axis result as default

* add it in index and README

* add inverse part

* update 1

* update 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants